Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[start_ursim] Always check ursim version for compatibility #203

Merged
merged 1 commit into from
May 29, 2024
Merged

[start_ursim] Always check ursim version for compatibility #203

merged 1 commit into from
May 29, 2024

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented May 23, 2024

Before, the version was only checked when explicitly specified. This could lead to errors if there was a local image with tag "latest" which was actually an old version.

This closes #191

I reproduced #191 locally by explicitly pulling an old image and tagging it "latest". With this PR applied things look like this:

dev@localhost:~$ docker image ls | grep e-series
universalrobots/ursim_e-series                                                 5.12.2                 21974ae9b4ac   20 months ago   1.15GB
universalrobots/ursim_e-series                                                 latest                 21974ae9b4ac   20 months ago   1.15GB
dev@localhost:~$ ./start_ursim.sh -m ur20
Illegal version given. For e-series UR20 the software version must be greater or equal to 5.14.0. Given version: 5.12.2.
dev@localhost:~$ docker pull universalrobots/ursim_e-series
Using default tag: latest
latest: Pulling from universalrobots/ursim_e-series
167b8a53ca45: Already exists
14035475613e: Pull complete
d9d83244cebc: Pull complete
f80ffd108710: Pull complete
faf03c45f9d9: Pull complete
4e1236dddca5: Pull complete
8d6907461581: Pull complete
b4aa331968d9: Pull complete
24339535ff6c: Pull complete
20c07bbb1ad3: Pull complete
44adcd6e4d41: Pull complete
6ef5e085bb30: Pull complete
92837dd7f4d1: Pull complete
Digest: sha256:37193210ea0d7f93736a40de1f771198e9ab43863f469b18845d1361317e3e62
Status: Downloaded newer image for universalrobots/ursim_e-series:latest
docker.io/universalrobots/ursim_e-series:latest
dev@localhost:~$ docker image ls | grep e-series
universalrobots/ursim_e-series                                                 latest                 fe8de22e2ae6   5 weeks ago     2.22GB
universalrobots/ursim_e-series                                                 5.12.2                 21974ae9b4ac   20 months ago   1.15GB
dev@localhost:~$ ./start_ursim.sh -m ur20
ursim_net already exists
784bbecadbaea58aac102d99cc38367bc7359f7619506b63744916a8a72ec74b
Docker URSim is running

To access Polyscope, open the following URL in a web browser.
        http://192.168.56.101:6080/vnc.html

To exit, press CTRL+C

@fmauch fmauch requested a review from VinDp May 23, 2024 10:18
@fmauch fmauch force-pushed the check_ursim_version branch from 53e97db to c0fa1b7 Compare May 28, 2024 09:54
@fmauch @VinDp
[start_ursim] Always check ursim version for compatibility
561cd01 
Before, the version was only checked when explicitly specified. This could lead to errors if there was a local image with tag "latest" which was actually an old version.
@VinDp VinDp force-pushed the check_ursim_version branch from c0fa1b7 to 561cd01 Compare May 29, 2024 11:50
@VinDp VinDp mentioned this pull request May 29, 2024
Closed
VinDp
VinDp approved these changes May 29, 2024
View reviewed changes
Copy link

@VinDp VinDp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely, good fix.

@VinDp VinDp merged commit 97af030 into UniversalRobots:master May 29, 2024
18 checks passed
@fmauch fmauch deleted the check_ursim_version branch September 24, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinDp VinDp VinDp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[start_ursim] Script does not check ursim version
2 participants
@fmauch @VinDp